Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C-API versioning discussion #5858

Closed
ailzhang opened this issue Aug 23, 2022 · 1 comment · Fixed by #7050
Closed

C-API versioning discussion #5858

ailzhang opened this issue Aug 23, 2022 · 1 comment · Fixed by #7050
Assignees
@PENGUINLIONG
Labels
discussion Welcome discussion!
Milestone
v1.4.0

Comments

@ailzhang
Copy link
Contributor

Current our C-API is tightly coupled with AOT data structures (due to serialization & deserialization), we should record when

  • an old python saved aot module stop working for capi runtime
    and figure out a proper way to release c-api runtime :D
@ailzhang ailzhang added the discussion Welcome discussion! label Aug 23, 2022
@ailzhang ailzhang added this to the v1.2.0 milestone Aug 23, 2022
@taichi-gardener taichi-gardener moved this to Untriaged in Taichi Lang Aug 23, 2022
@ailzhang ailzhang moved this from Untriaged to Todo in Taichi Lang Aug 26, 2022
@jim19930609 jim19930609 modified the milestones: v1.2.0, v1.3.0 Oct 18, 2022
@PENGUINLIONG PENGUINLIONG modified the milestones: v1.3.0, v1.4.0 Nov 25, 2022
@ailzhang
Copy link
Contributor Author

ailzhang commented Jan 4, 2023

as discussed offline with @PENGUINLIONG , we might just serialize the git commit hash and warn users about potential risk and resolve backward compatibility & forward compatibility for future releases.

@PENGUINLIONG PENGUINLIONG mentioned this issue Jan 4, 2023
Merged
@PENGUINLIONG PENGUINLIONG linked a pull request Jan 5, 2023 that will close this issue
[aot] C-API versioning #7050
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Taichi Lang Jan 5, 2023
PENGUINLIONG added a commit that referenced this issue Jan 5, 2023
@PENGUINLIONG @pre-commit-ci
[aot] C-API versioning (#7050)
39a6a76 
Issue: #5858

### Brief Summary

This PR introduces a versioning mechanism to the Taichi Runtime C-API.
Taichi Runtime has the same version as the Python frontend. The version
information can be queried from taichi header definition
`TI_C_API_VERSION`, C-API `ti_get_version`, `__version__` in compiled
AOT module, and log output when `ti_create_runtime` is called.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
feisuzhu pushed a commit to feisuzhu/taichi that referenced this issue Jan 5, 2023
@PENGUINLIONG @pre-commit-ci @feisuzhu
[aot] C-API versioning (taichi-dev#7050)
f1cf547 
Issue: taichi-dev#5858

### Brief Summary

This PR introduces a versioning mechanism to the Taichi Runtime C-API.
Taichi Runtime has the same version as the Python frontend. The version
information can be queried from taichi header definition
`TI_C_API_VERSION`, C-API `ti_get_version`, `__version__` in compiled
AOT module, and log output when `ti_create_runtime` is called.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
quadpixels pushed a commit to quadpixels/taichi that referenced this issue May 13, 2023
@PENGUINLIONG @pre-commit-ci @quadpixels
[aot] C-API versioning (taichi-dev#7050)
af8e17f 
Issue: taichi-dev#5858

### Brief Summary

This PR introduces a versioning mechanism to the Taichi Runtime C-API.
Taichi Runtime has the same version as the Python frontend. The version
information can be queried from taichi header definition
`TI_C_API_VERSION`, C-API `ti_get_version`, `__version__` in compiled
AOT module, and log output when `ti_create_runtime` is called.

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PENGUINLIONG PENGUINLIONG

Labels
discussion Welcome discussion!
Projects
Taichi Lang
Status: Done
Milestone
v1.4.0
Development

Successfully merging a pull request may close this issue.

[aot] C-API versioning PENGUINLIONG/taichi
3 participants
@PENGUINLIONG @ailzhang @jim19930609