Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CPP/Python linter #2624

Open
k-ye opened this issue Aug 1, 2021 · 4 comments
Open

Setup CPP/Python linter #2624

k-ye opened this issue Aug 1, 2021 · 4 comments
Labels
feature request Suggest an idea on this project

Comments

@k-ye
Copy link
Member

k-ye commented Aug 1, 2021

If possible, I'd like bots to take over my job of making comments like "add an _ suffix" 😂

Possible solution:

https://github.com/github/super-linter

@k-ye k-ye added feature request Suggest an idea on this project engprod labels Aug 1, 2021
@k-ye k-ye mentioned this issue Aug 1, 2021
43 tasks
@bobcao3
Copy link
Collaborator

bobcao3 commented Aug 1, 2021

Is the suffix a part of chromium or Google coding style? If it is clang format should take care of it? I saw in the clang format file the based on line is commented

@k-ye
Copy link
Member Author

k-ye commented Aug 2, 2021

Is the suffix a part of chromium or Google coding style?

Both

I saw in the clang format file the based on line is commented

Yeah, it could be because we don't follow the function naming convention in Taichi?

@bobcao3
Copy link
Collaborator

bobcao3 commented Aug 2, 2021 via email

@k-ye
Copy link
Member Author

k-ye commented Aug 2, 2021

I believe so, but haven't really systematically learnt clang-format

@ailzhang ailzhang removed the engprod label Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Suggest an idea on this project
Projects
None yet
Development

No branches or pull requests

3 participants