[Lang] Remove the deprecated dynamic_index switch (#7195)

Issue: #2590 ### Brief Summary The `dynamic_index` switch of `ti.init()` should be removed according to the [deprecation notice](https://github.com/taichi-dev/taichi/releases/tag/v1.4.0).
taichi-dev · Jan 17, 2023 · dfac43a · dfac43a
1 parent 30496a0
commit dfac43a
Show file tree

Hide file tree

Showing 8 changed files with 8 additions and 29 deletions.
diff --git a/python/taichi/lang/misc.py b/python/taichi/lang/misc.py
@@ -184,7 +184,7 @@
 
 The list of currently available extensions is ['sparse', 'quant', \
     'mesh', 'quant_basic', 'data64', 'adstack', 'bls', 'assertion', \
-        'extfunc', 'dynamic_index'].
+        'extfunc'].
 """
 
 
@@ -360,11 +360,6 @@ def init(arch=None,
     if require_version is not None:
         check_require_version(require_version)
 
-    if "dynamic_index" in kwargs:
-        warnings.warn(
-            "Dynamic index is supported by default and the switch will be removed in v1.5.0.",
-            DeprecationWarning)
-
     if "default_up" in kwargs:
         raise KeyError(
             "'default_up' is always the unsigned type of 'default_ip'. Please set 'default_ip' instead."

diff --git a/taichi/analysis/offline_cache_util.cpp b/taichi/analysis/offline_cache_util.cpp
@@ -62,7 +62,6 @@ static std::vector<std::uint8_t> get_offline_cache_key_of_compile_config(
   serializer(config->demote_no_access_mesh_fors);
   serializer(config->experimental_auto_mesh_local);
   serializer(config->auto_mesh_local_default_occupacy);
-  serializer(config->dynamic_index);
   serializer(config->real_matrix_scalarize);
   serializer.finalize();
 

diff --git a/taichi/inc/extensions.inc.h b/taichi/inc/extensions.inc.h
@@ -8,5 +8,3 @@ PER_EXTENSION(adstack)    // For keeping the history of mutable local variables
 PER_EXTENSION(bls)        // Block-local storage
 PER_EXTENSION(assertion)  // Run-time asserts in Taichi kernels
 PER_EXTENSION(extfunc)    // Invoke external functions or backend source
-PER_EXTENSION(
-    dynamic_index)  // Dynamic index support for both global and local tensors
diff --git a/taichi/program/compile_config.cpp b/taichi/program/compile_config.cpp
@@ -39,7 +39,6 @@ CompileConfig::CompileConfig() {
   gpu_max_reg = 0;  // 0 means using the default value from the CUDA driver.
   verbose = true;
   fast_math = true;
-  dynamic_index = true;
   flatten_if = false;
   make_thread_local = true;
   make_block_local = true;

diff --git a/taichi/program/compile_config.h b/taichi/program/compile_config.h
@@ -34,7 +34,6 @@ struct CompileConfig {
   bool timeline{false};
   bool verbose;
   bool fast_math;
-  bool dynamic_index;
   bool flatten_if;
   bool make_thread_local;
   bool make_block_local;

diff --git a/taichi/program/extension.cpp b/taichi/program/extension.cpp
@@ -10,20 +10,20 @@ bool is_extension_supported(Arch arch, Extension ext) {
       {Arch::x64,
        {Extension::sparse, Extension::quant, Extension::quant_basic,
         Extension::data64, Extension::adstack, Extension::assertion,
-        Extension::extfunc, Extension::dynamic_index, Extension::mesh}},
+        Extension::extfunc, Extension::mesh}},
       {Arch::arm64,
        {Extension::sparse, Extension::quant, Extension::quant_basic,
         Extension::data64, Extension::adstack, Extension::assertion,
-        Extension::dynamic_index, Extension::mesh}},
+        Extension::mesh}},
       {Arch::cuda,
        {Extension::sparse, Extension::quant, Extension::quant_basic,
         Extension::data64, Extension::adstack, Extension::bls,
-        Extension::assertion, Extension::dynamic_index, Extension::mesh}},
-      {Arch::metal, {Extension::dynamic_index}},
-      {Arch::opengl, {Extension::dynamic_index, Extension::extfunc}},
+        Extension::assertion, Extension::mesh}},
+      {Arch::metal, {}},
+      {Arch::opengl, {Extension::extfunc}},
       {Arch::gles, {}},
-      {Arch::vulkan, {Extension::dynamic_index}},
-      {Arch::dx11, {Extension::dynamic_index}},
+      {Arch::vulkan, {}},
+      {Arch::dx11, {}},
       {Arch::cc, {Extension::data64, Extension::extfunc, Extension::adstack}},
   };
   // if (with_opengl_extension_data64())

diff --git a/taichi/python/export_lang.cpp b/taichi/python/export_lang.cpp
@@ -189,7 +189,6 @@ void export_lang(py::module &m) {
       .def_readwrite("advanced_optimization",
                      &CompileConfig::advanced_optimization)
       .def_readwrite("ad_stack_size", &CompileConfig::ad_stack_size)
-      .def_readwrite("dynamic_index", &CompileConfig::dynamic_index)
       .def_readwrite("flatten_if", &CompileConfig::flatten_if)
       .def_readwrite("make_thread_local", &CompileConfig::make_thread_local)
       .def_readwrite("make_block_local", &CompileConfig::make_block_local)

diff --git a/tests/python/test_deprecation.py b/tests/python/test_deprecation.py
@@ -135,13 +135,3 @@ def ker(tex: ti.types.rw_texture(num_dimensions=2, lod=0)):
             for i, j in ti.ndrange(n, n):
                 ret = ti.cast(1, ti.f32)
                 tex.store(ti.Vector([i, j]), ti.Vector([ret, 0.0, 0.0, 0.0]))
-
-
-@pytest.mark.parametrize("value", [True, False])
-def test_deprecated_dynamic_index(value):
-    with pytest.warns(
-            DeprecationWarning,
-            match=
-            "Dynamic index is supported by default and the switch will be removed in v1.5.0."
-    ):
-        ti.init(dynamic_index=value)