Skip to content

Commit

Permalink
[CI] Recheck the title format when user updates the title (#3403)
Browse files Browse the repository at this point in the history
* [CI] recheck the title format when user updates the title

* fix presubmit error

Co-authored-by: Ailing <[email protected]>
  • Loading branch information
Zheaoli and ailzhang authored Nov 8, 2021
1 parent bb68caf commit def95bd
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 17 deletions.
17 changes: 0 additions & 17 deletions .github/workflows/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,6 @@ on:
types: [opened, synchronize, reopened]

jobs:
title_format:
name: Check PR Title
if: ${{ github.event.pull_request }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
with:
python-version: 3.8

- name: Run PR Title Checker
run: |
pip install semver GitPython
python misc/ci_check_pr_title.py "$PR_TITLE"
env:
PR_TITLE: ${{ github.event.pull_request.title }}
check_files:
name: Check files
outputs:
Expand Down Expand Up @@ -50,7 +34,6 @@ jobs:
echo "::set-output name=run_job::true"
fi
done < files.txt
check_code_format:
name: Check Code Format
runs-on: ubuntu-latest
Expand Down
22 changes: 22 additions & 0 deletions .github/workflows/title_check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
name: Presubmit Title Checks
on:
pull_request:
types: [opened, synchronize, reopened, edited]

jobs:
title_format:
name: Check PR Title
if: ${{ github.event.pull_request }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
with:
python-version: 3.8

- name: Run PR Title Checker
run: |
pip install semver GitPython
python misc/ci_check_pr_title.py "$PR_TITLE"
env:
PR_TITLE: ${{ github.event.pull_request.title }}

0 comments on commit def95bd

Please sign in to comment.