-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve "xs:list deserialization does not split on all whitespace" #843
base: master
Are you sure you want to change the base?
Conversation
…rious types of possible delimiters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR. I would like to have:
- a new test that ensures that bug is fixed
- a changelog entry informing users that bug is fixed
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #843 +/- ##
==========================================
+ Coverage 60.21% 60.56% +0.35%
==========================================
Files 41 41
Lines 16021 15951 -70
==========================================
+ Hits 9647 9661 +14
+ Misses 6374 6290 -84
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Changed DELIMITER (u8) into an array DELIMITERS (u8; 4) that holds 4 possible delimiters.
This was implemented with issue #839 in mind, so I covered the following whitespaces:
,
\t
,\r
,\n
. It is fairly easy to include more if necessary.