Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve "xs:list deserialization does not split on all whitespace" #843

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

JGM01
Copy link

@JGM01 JGM01 commented Feb 1, 2025

Changed DELIMITER (u8) into an array DELIMITERS (u8; 4) that holds 4 possible delimiters.

This was implemented with issue #839 in mind, so I covered the following whitespaces: , \t, \r, \n. It is fairly easy to include more if necessary.

src/de/simple_type.rs Outdated Show resolved Hide resolved
src/de/simple_type.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Mingun Mingun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR. I would like to have:

  • a new test that ensures that bug is fixed
  • a changelog entry informing users that bug is fixed

src/de/simple_type.rs Outdated Show resolved Hide resolved
src/de/simple_type.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.56%. Comparing base (a9391f3) to head (b86f89a).
Report is 26 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
+ Coverage   60.21%   60.56%   +0.35%     
==========================================
  Files          41       41              
  Lines       16021    15951      -70     
==========================================
+ Hits         9647     9661      +14     
+ Misses       6374     6290      -84     
Flag Coverage Δ
unittests 60.56% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JGM01 JGM01 requested a review from Mingun February 2, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants