Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Errors more "narrow" #811

Merged
merged 10 commits into from
Oct 12, 2024
Merged

Make Errors more "narrow" #811

merged 10 commits into from
Oct 12, 2024

Commits on Oct 12, 2024

  1. Make all error test started from lower-case letter

    @Mingun
    Mingun committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    d112667 View commit details
    Browse the repository at this point in the history

  2. Do not use write! macro when not required and slightly improve number… 

    … deserialization error messages

More clear and may slightly increase compile time
    @Mingun
    Mingun committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    82cfe51 View commit details
    Browse the repository at this point in the history

  3. Use Self in match expressions and from implementations instead of nam… 

    …e of type

Make code more consistent
    @Mingun
    Mingun committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    13d14ce View commit details
    Browse the repository at this point in the history

  4. Split NamespaceError from the Error type

    @RedPhoenixQ @Mingun
    RedPhoenixQ authored and Mingun committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    6dbd39a View commit details
    Browse the repository at this point in the history

  5. Split EncodingError from the Error type 

    This mostly allows for decode functions to return a smaller more
accurate error
    @RedPhoenixQ @Mingun
    RedPhoenixQ authored and Mingun committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    a975a82 View commit details
    Browse the repository at this point in the history

  6. Rename EscapeError variant to match others

    @RedPhoenixQ @Mingun
    RedPhoenixQ authored and Mingun committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    e36d743 View commit details
    Browse the repository at this point in the history

  7. Return SyntaxError from BangType

    @RedPhoenixQ @Mingun
    RedPhoenixQ authored and Mingun committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    38e11c7 View commit details
    Browse the repository at this point in the history

  8. Return AttrError from attribute methods

    @RedPhoenixQ @Mingun
    RedPhoenixQ authored and Mingun committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    d35e497 View commit details
    Browse the repository at this point in the history

  9. Split reserved namespace binding errors

    @RedPhoenixQ @Mingun
    RedPhoenixQ authored and Mingun committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    8a3a140 View commit details
    Browse the repository at this point in the history

  10. Use assert_eq! instead of manual matches because now NamespaceError i… 

    …mplements PartialEq
    @Mingun
    Mingun committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    00a0962 View commit details
    Browse the repository at this point in the history