-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An error was reported when loading a custom dictionary. #15
Comments
There is indeed a limit to the size of the dictionary file, I divided it into multiple files of appropriate size, and it can be used normally. Super awesome, thank you very much for your development! |
@tyf2018 Would you tell me the size of the file that occurred error? I use Obsidian API to read local files, so I want to know the limit of size. |
The result of my own verification is that the dictionary file should not be larger than 1.3Mb. If the file is very large, it is recommended to divide it into multiple small files. At present, I have divided about 110 dictionary files, which are in good use. The above data is likely to be inaccurate and is for reference only. |
@tyf2018
Oh.. it is too large more than expected 😅 I think it is better that |
Do you mean to let custom dictionary paths support regular expressions? This function is not that important to me. In fact, I don't know the regularity well and only use a few simple rules. But for those who understand regularity, it should be needed. |
Yes, or glob patterns. If it is not essential for you, I will not add it, for now, thanks! |
This is a bug in my code.. it occurs a Maximum call stack size exceeded error 😅 this.customTokens.push(
...str.split(/(\r\n|\n)/).filter((x) => x !== "")
); |
Great, the new version has no restrictions on the size of dictionary files. My 20Mb file is used normally. |
An error was reported when loading a custom dictionary.
Are there any special restrictions on the size or encoding of dictionary files?
Best Regards.
The text was updated successfully, but these errors were encountered: