-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Use JSONs for Custom Dictionaries #108
Comments
Hi, @chrisgrieser. I couldn't understand why using the JSON format could solve that problem. 🤔
Could you tell me the link to the comment? |
Markdown files are scanned for metadata. It is not recommended to have content in markdown files that isn't markdown, because it trips up the parser and can make Obsidian slow. That has happened with XML files that had the md extension in the past, for example. Additionally, using the JSON format should also make it easier to create data/have easier compatibility and can be very easily read and worked with in JavaScript. |
Plugins that use JSON are e.g. Obsidian Wordnet and Linked Data Vocabularies. |
@kometenstaub
Good. I have the same understanding as you :)
I adopted the textbase format because I gave priority to human readability/writability, JSON is a little redundant for humans, and some IME dictionary format supports the same. (Of course, it is better to support both formats) @chrisgrieser |
Yes, other extensions should work fine. |
yeah, txt would work! I just tested adding a .txt as a custom dictionary, and it does seem to be recognized (number of items in the status bar increases), but the editor suggester does not appear for them. |
ah, my bad, haven't properly refresh the custom dictionaries 🙈 works! |
Related to #118 |
@chrisgrieser |
by now I do not have the need for json custom dictionaries, since your other suggested solutions works just fine for me, sorry! 😅 |
Sure! I know 👍 That is merely sharing information 😄 |
Released v6.1.0 🚀 |
I have encountered a few bugs with various plugins in Obsidian, which, as I could determine, was caused by having a large custom dictionary file (~3800 lines, ~425kb) in my vault:
BC-tag-note
breaks Breadcrumbs Indexing. SkepticMystic/breadcrumbs#361metadata.json
cannot be written anymore kometenstaub/metadata-extractor#17 (this issue also includes more details)it seems that Obsidian is simply having problems parsing large files, since it unsuccessfully searches for metadata in such a large file. the developer of the metadata extractor plugin suggested, that Various Complements should use JSON as a format for large custom dictionaries to avoid such problems, as well to increase performance Various complements as well as Obsidian in general.
The text was updated successfully, but these errors were encountered: