-
-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Search by text" (aka regex search) #922
base: master
Are you sure you want to change the base?
Conversation
… Data page, current issue with a stale element exception being thrown but should be able to fix it.
…t of the component testing! What isn't tested, which is just one button is mentioned why on the test case- shouldn't affect the overall functionality and am okay if that button is not tested for; other comments and small things to fix are mentioned in the comments. Will begin the user scenario testing with the first round of pdf files.
…t will fix why the build is failing
… to see if it will work
…irefoxDriver, added on a better solution for calling the pdf file in order to utilize it in the test cases, as well as being able to delete the file once done.
…r/footer scale, update back-end parsing to accommodate multiple user-drawn rectangles for a single program invocation.....
…gex search disabled button
…and pattern before
…ern before and pattern after and checks that there are zero results
… input to pattern before and pattern after
…me previous test cases
…s, have changed it for it to only refresh when the menu bar disappears. Doesn't necessary hurt if the pdf bar or pdf view is not present since it doesn't affect the test cases. Will be updating this method to previous test cases that need it. Also implemented a more correct way to verify tabula is gathering the correct data based on the output
…hpage method, as well as added on the extra data verification for regex inputs. Will move on to the next set of user scenarios
…more test scenarios that use inclusive
…on method deciders....
…iple Page Regex Test Should now pass...furthermore, the extraction options have been explicitly baked into the command line option so that this ambiguity *should* not be encountered in the future...should be noted that it is an ongoing issue within Tabula regarding extraction methods when multiple tables are specified....
…...NOTE: still need to manually test the options to double-check the command line unit tests
…ader_Addition # Conflicts: # .idea/workspace.xml
…nning table. The 5 page spanning table scenario is running into an internal error, and after confirming with Ben testing out the scenario as well, this may be something we may have to further look into.
…ng_sit_list_nov2012 pdf file
…s (calculate scale in front-end for data efficiency + simpler to generate CLI args)
…ll move on to work on the test case for multiple regex searches
…ed Select by Text
…is shown; also templatizes social media nav bar
…les added to your library
Thanks for taking care of this, @jeremybmerrill — I'll try to find some time this weekend to review. BTW, I went ahead and deleted some files from the root directory (old versions of the PDFBox jar (!), an IDEA .iml file, et cetera) |
BTW, we should do a merge from |
Thanks. I'll check out merging master back in when I get a chance. (It can't be that old, can it? It's not like there've been many commits in the past year.) |
True. I mentioned that anyway because of the list of conflicted files that Github shows:
|
@jazzido : I think I fixed the conflicts. I'm not sure exactly where you were looking, but can you check again? I'm not sure why only one of the Travis checks passed, but the other failed. Might just be a sporadic erro (the thing that failed is just checking for a button's presence... and that button is there (and it works on my computer).) |
Does this branch/PR make it possible to select/position tables relative to the xy coordinates of search text in a PDF document? I recently opened a feature request issue for this feature: |
supersedes #873 by @slmendez et al.
@jazzido, @mtigas would love your eyes on this one. I propose that we aim to do a Beta/Preview release, so some users can take it for a spin and give us feedback. Then see where we're at.
I've done some substantial cleanup, moving raw CSS into SCSS, rewriting some event handlers, putting templates in the right kinds of places, putting the Search by Text toolbar behind a button. I also wrote through all the copy.
The Regex Search I've renamed
Search by text
so non-regex aware users can use it (but the guts are the same, it still supports regex). One question I'm still pondering is whether the searches created by the regex search should be individually deleteable/movable/editable.One big win from this is testing:
mvn test
tests the UI, which is a thing we've needed for a few years.