Allow injection of sessions #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @MrwanBaghdad to sign the Salesforce.com Contributor License Agreement. |
|
@jacalata Can you please take a look? |
|
Very nice! We do have another call where it sets _session = requests.Session() in the _set_auth() method - does that need to be overridden or updated somehow as well? I've also rebased this for you onto our new dev branch. |
within the server lifecycle specific usecase is when calling `_clear_auth`
|
@jacalata That's a good point. I've updated the PR to allow injection of a callable |
jacalata
added a commit
that referenced
this pull request
Feb 14, 2023
* Allow injection of sessions (#1111) * show server info (#1118) * Fix bug in exposing ExcelRequestOptions and test (#1123) * Fix a few pylint errors (#1124) * fix behavior when url has no protocol (#1125) * Add permission control for Data Roles and Metrics (Issue #1063) (#1120) * add option to pass specific datasources (#1150) * allow user agent to be set by caller (#1166) * Fix issues with connections publishing workbooks (#1171) * Allow download to file-like objects (#1172) * Add updated_at to JobItem class (#1182) * fix revision references where xml returned does not match docs (#1176) * Do not create empty connections list (#1178) --------- Co-authored-by: Marwan Baghdad <[email protected]> Co-authored-by: jorwoods <[email protected]> Co-authored-by: Brian Cantoni <[email protected]> Co-authored-by: TrimPeachu <[email protected]> Co-authored-by: Stu Tomlinson <[email protected]> Co-authored-by: Jeremy Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows injection of
requests.Sessionobjects.This covers use cases when an end user may want to have more control over the session in case of proxies, custom authentication flows enforced by proxies in front of the Tableau server, and custom headers need to be injected to allow access to the Tableau server.