Fix a few pylint errors (#1124)

Pylint with "errors only" isn't 100% accurate, but it found a few problems
that should be fixed.

samples/initialize_server.py

@@ -56,15 +56,15 @@ def main():
 
         # Create the site if it doesn't exist
         if existing_site is None:
-            print("Site not found: {0} Creating it...").format(args.site_id)
+            print("Site not found: {0} Creating it...".format(args.site_id))
             new_site = TSC.SiteItem(
                 name=args.site_id,
                 content_url=args.site_id.replace(" ", ""),
                 admin_mode=TSC.SiteItem.AdminMode.ContentAndUsers,
             )
             server.sites.create(new_site)
         else:
-            print("Site {0} exists. Moving on...").format(args.site_id)
+            print("Site {0} exists. Moving on...".format(args.site_id))
 
     ################################################################################
     # Step 3: Sign-in to our target site
@@ -87,7 +87,7 @@ def main():
 
         # Create our project if it doesn't exist
         if project is None:
-            print("Project not found: {0} Creating it...").format(args.project)
+            print("Project not found: {0} Creating it...".format(args.project))
             new_project = TSC.ProjectItem(name=args.project)
             project = server_upload.projects.create(new_project)
 

tableauserverclient/models/flow_item.py

@@ -93,10 +93,6 @@ def description(self, value: str) -> None:
     def project_name(self) -> Optional[str]:
         return self._project_name
 
-    @property
-    def flow_type(self):  # What is this? It doesn't seem to get set anywhere.
-        return self._flow_type
-
     @property
     def updated_at(self) -> Optional["datetime.datetime"]:
         return self._updated_at

tableauserverclient/models/permissions_item.py

@@ -69,7 +69,7 @@ def from_response(cls, resp, ns=None) -> List["PermissionsRule"]:
                 mode = capability_xml.get("mode")
 
                 if name is None or mode is None:
-                    logger.error("Capability was not valid: ", capability_xml)
+                    logger.error("Capability was not valid: {}".format(capability_xml))
                     raise UnpopulatedPropertyError()
                 else:
                     capability_dict[name] = mode

tableauserverclient/models/revision_item.py

@@ -53,8 +53,9 @@ def user_name(self) -> Optional[str]:
 
     def __repr__(self):
         return (
-            "<RevisionItem# revisionNumber={_revision_number} " "current={_current} deleted={_deleted} user={_user_id}>"
-        ).format(**self.__dict__)
+            "<RevisionItem# revisionNumber={_revision_number} "
+            "current={_current} deleted={_deleted} user={_user_id}>".format(**self.__dict__)
+        )
 
     @classmethod
     def from_response(cls, resp: bytes, ns, resource_item) -> List["RevisionItem"]:

tableauserverclient/models/tableau_auth.py

@@ -9,7 +9,7 @@ def credentials(self):
         +"This method returns values to set as an attribute on the credentials element of the request"
 
     def __repr__(self):
-        display = "All Credentials types must have a debug display that does not print secrets"
+        return "All Credentials types must have a debug display that does not print secrets"
 
 
 def deprecate_site_attribute():

tableauserverclient/server/endpoint/databases_endpoint.py

@@ -116,7 +116,7 @@ def update_table_default_permissions(self, item):
 
     @api(version="3.5")
     def delete_table_default_permissions(self, item):
-        self._default_permissions.delete_default_permissions(item, Resource.Table)
+        self._default_permissions.delete_default_permission(item, Resource.Table)
 
     @api(version="3.5")
     def populate_dqw(self, item):