Migrate Menu to Material UI v5 #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TasoOneAsia
added
dependencies
Also removes unnecessary old @material-ui/* packages
TasoOneAsia
force-pushed
the
migrate/mui-v5
branch
from
a6cfbf1 to
6f81f0a
Compare
|
Material UI v5 has been officially released and is ready for production. This pull request has been updated from RC deps to the production deps. From my testing, this migration hasn't resulted in any unintentional styling or functionality changes and should be ready for merge. @tabarra Am I good to merge into develop? |
|
retracted: notistack fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Material UI RC v5 has recently been released, we should begin to migrate towards it. There is one dependency that does not yet support Material UI v5 officially (notistack), so this PR may be updated to use that when available.
Aside from that dependency, this migration should go off without a hitch.