Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is_complete_sentence(char) in main.py #31

Closed
miivalj opened this issue Oct 30, 2024 · 1 comment
Closed

is_complete_sentence(char) in main.py #31

miivalj opened this issue Oct 30, 2024 · 1 comment

Comments

@miivalj
Copy link

miivalj commented Oct 30, 2024

Commit 9880a7f appears to conflict with the intended functionality of the is_complete_sentence method.

Currently speak_by_sentence_chain splits "I am Mr. Smith" into two sentences, which disrupts the intended flow of speech.
t41372 added a commit that referenced this issue Oct 31, 2024
@t41372
Revert "minor change" as per #31
5b93d62 
This reverts commit 9880a7f.
@t41372
Copy link
Owner

t41372 commented Oct 31, 2024

You know what? You are absolutely correct. Apparently I was thinking about optimization but didn't really know what I was doing. Thank you for catching that.

@t41372 t41372 closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t41372 @miivalj