Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolved database startup script not checking docker daemon status @0pilatos0 #1975

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

0pilatos0
Copy link
Contributor

Closes #1974

✅ Checklist

  • I have followed every step in the contributing guide (updated 2022-10-06).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

added an extra check in the initial steps of the start-database.sh script to check if the docker daemon is up and running to prevent the script from continuing with for example generating the password


Examples

before:

❯ ./start-database.sh
Cannot connect to the Docker daemon at unix:///Users/paulvanderlei/.docker/run/docker.sock. Is the docker daemon running?
Cannot connect to the Docker daemon at unix:///Users/paulvanderlei/.docker/run/docker.sock. Is the docker daemon running?
You are using the default database password
Should we generate a random password for you? [y/N]:

after:

❯ ./start-database.sh
Docker deamon is not up and running. Please start docker and try again.

💯

Copy link

changeset-bot bot commented Aug 31, 2024

🦋 Changeset detected

Latest commit: 7a87f46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Aug 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-t3-app ✅ Ready (Inspect) Visit Preview 💬 1 unresolved
✅ 1 resolved
Aug 31, 2024 9:54am

Copy link

vercel bot commented Aug 31, 2024

@0pilatos0 is attempting to deploy a commit to the t3-oss Team on Vercel.

A member of the Team first needs to authorize it.

@juliusmarminge juliusmarminge merged commit 78cb06f into t3-oss:main Oct 3, 2024
265 of 266 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: start-database.sh does not check for the docker deamon to be up and running
2 participants