Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

パッケージマネージャを yarn に変更 #127

Merged
merged 1 commit into from
Nov 26, 2021
Merged

パッケージマネージャを yarn に変更 #127

merged 1 commit into from
Nov 26, 2021

Conversation

mojahige
Copy link
Contributor

@mojahige mojahige commented Nov 26, 2021 •
edited
Loading

close #126

pnpm を使用して build し、出来上がったアプリを起動させようとするとエラーメッセージが表示されて使用できない。
仕組み上の問題のようなので、パッケージマネージャを yarn に変更した。

変更内容

  • pnpm 関連のファイル削除
  • node_modules を削除してから yarn install し yarn.lock 生成
  • Prettier で yarn.lock を無視するように変更
  • npm scripts と lint-staged で yarn を使用するように変更
  • GitHub Actions で yarn を使用するように変更

@mojahige mojahige marked this pull request as ready for review November 26, 2021 00:15
@mojahige mojahige requested a review from t-yng November 26, 2021 03:41
@mojahige mojahige self-assigned this Nov 26, 2021
t-yng
t-yng approved these changes Nov 26, 2021
View reviewed changes
Copy link
Owner

@t-yng t-yng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

変更ありがとうございます！
(･ω･)b < LGTM

@mojahige mojahige merged commit 15435b6 into main Nov 26, 2021
@mojahige mojahige deleted the fix-error-when-launch-app branch November 26, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-yng t-yng t-yng approved these changes

Assignees

@mojahige mojahige

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ビルドしたアプリを立ち上げるとエラーメッセージが表示され使用できない
2 participants
@mojahige @t-yng