Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test with PHP 8.1 as well #52

Merged
merged 1 commit into from
Dec 17, 2021
Merged

Test with PHP 8.1 as well #52

merged 1 commit into from
Dec 17, 2021

Conversation

oliverklee
Copy link
Collaborator

No description provided.

@oliverklee oliverklee self-assigned this Aug 2, 2021
@oliverklee oliverklee marked this pull request as draft August 2, 2021 13:26
@oliverklee oliverklee added the enhancement New feature or request label Aug 2, 2021
@oliverklee oliverklee force-pushed the feature/php-81-linting branch 3 times, most recently from bc2f699 to f10fdef Compare August 2, 2021 13:33
@danon
Copy link
Member

danon commented Aug 2, 2021

I have similar problem with dependencies in T-Regx.

https://github.com/T-Regx/T-Regx/runs/2712930290

Any idea?

@oliverklee oliverklee force-pushed the feature/php-81-linting branch from f10fdef to fb29efc Compare August 2, 2021 15:32
@oliverklee
Copy link
Collaborator Author

phpspec/prophecy does not support PHP 8.1 yet, it seems. There's already a PR for this: phpspec/prophecy#533

@danon
Copy link
Member

danon commented Sep 10, 2021 •
edited
Loading

@oliverklee Seeing how phpspec/prophecy#533 is merged, do you think we can update phpspec, so it runs on PHP 8.1?

@oliverklee oliverklee force-pushed the feature/php-81-linting branch from fb29efc to de23a05 Compare September 15, 2021 11:19
@oliverklee oliverklee requested a review from danon September 15, 2021 11:20
@oliverklee oliverklee marked this pull request as ready for review September 15, 2021 11:20
@danon danon merged commit 678ad21 into t-regx:master Dec 17, 2021
@oliverklee oliverklee deleted the feature/php-81-linting branch December 17, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danon danon Awaiting requested review from danon

Assignees

@oliverklee oliverklee

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @danon