Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XDEBUG_MODE=coverage for executing PHPUnit #98

Conversation

peter279k
Copy link
Contributor

Overview

  • Adding the XDEBUG_MODE=coverage to fix warning message:
Warning:       XDEBUG_MODE=coverage or xdebug.mode=coverage has to be set

@danon
Copy link
Member

danon commented Mar 14, 2021

Thank you very much for contribution!

But I'm buffled. The tests currently aren't run by xdebug in tarivs, so wouldn't the XDEBUG_MODE flag be ignored?

Second of all, the coverage is being generated as we speak, look: https://coveralls.io/github/T-Regx/T-Regx?branch=master :)There's even a coverage badge in the ReadMe.md.

@peter279k
Copy link
Contributor Author

  • It seems that the warning message is generated when executing the PHPUnit 9.x version.

I'm going to close this PR as you say this warning message can be ignored at this moment :).

@peter279k peter279k closed this Mar 14, 2021
@peter279k peter279k deleted the add_xdebug_mode_env branch March 14, 2021 11:16
@danon
Copy link
Member

danon commented Mar 14, 2021

@peter279k I just said I didn't see the reasons behind it. If as you say, there's a reason for that flag, just like PhpUnit warning suggested, maybe it's worth adding.

Did you hear about it from this link: sebastianbergmann/php-code-coverage#834 ?

@peter279k
Copy link
Contributor Author

Just notice that the PHPUnit can support two different approaches about coverage.

One is the XDebug and another one is pcov.

If the current PHP version supports and enables pcov extension, it will not print above warning message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants