write_fill_pdf flatten parameter now preserves multiline edit fields #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
write_fill_pdf flatten option must set first bit of /Ff field but must preserve the other bits. Form fields with multiline option (bitmask 4096) where being transformed into single line by setting /Ff to 1. See https://stackoverflow.com/questions/68119744/python-how-to-properly-fill-a-multiline-text-field-in-pdf-form-using-pdfrw and https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/pdfreference1.4.pdf, page 552 for a description of /Ff bitmask
Additional field in write_fillable_pdf has addition fontinfo parameter. None by default, uses PDF DA format, as example 'Arial 8.00 Tf 0 g' and changes the edit fields to this font, instead of the font present in the pdf template.
t-houssian
requested changes
May 3, 2024
There was a problem hiding this comment.
Looks great! I just pulled in another PR that I believe has fixed part of this. If you could edit the PR to just have the fontinfo part and fix the merge conflict I can merge this in! @josevenceslau
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
write_fill_pdf flatten option must set first bit of /Ff field but must preserve the other bits.
Form fields with multiline option (bitmask 4096) where being transformed into single line by setting /Ff to 1, this patch preserves the Ff bit mask if fields any form field has multiple line bit set.
See https://stackoverflow.com/questions/68119744/python-how-to-properly-fill-a-multiline-text-field-in-pdf-form-using-pdfrw and https://opensource.adobe.com/dc-acrobat-sdk-docs/pdfstandards/pdfreference1.4.pdf, page 552 for a description of /Ff bitmask