removed id validation (Azure#7010)

szimmer-dev · Jul 24, 2019 · 39b91f4 · 39b91f4
1 parent 81fd337
commit 39b91f4
Show file tree

Hide file tree

Showing 31 changed files with 197 additions and 445 deletions.
diff --git a/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/changelog.md b/sdk/apimanagement/Microsoft.Azure.Management.ApiManagement/changelog.md
@@ -1,5 +1,9 @@
 ## Microsoft.Azure.Management.ApiManagment release notes
 
+### Changes in 4.11.0-preview
+
+- Removed id validation on `groups`, `apis`, `products`, `users` and `backend` to unblock existing customers to onboard to new sdks
+
 ### Changes in 4.10.0-preview
 
 - Fixed support for creating, updating Swagger, WSDL and Open Api Schema.

diff --git a/...agement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiDiagnosticOperations.cs b/...agement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiDiagnosticOperations.cs
@@ -127,10 +127,6 @@ internal ApiDiagnosticOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (Client.ApiVersion == null)
             {
@@ -369,10 +365,6 @@ internal ApiDiagnosticOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (diagnosticId == null)
             {
@@ -620,10 +612,6 @@ internal ApiDiagnosticOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (diagnosticId == null)
             {
@@ -896,10 +884,6 @@ internal ApiDiagnosticOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (diagnosticId == null)
             {
@@ -1213,10 +1197,6 @@ internal ApiDiagnosticOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (diagnosticId == null)
             {
@@ -1477,10 +1457,6 @@ internal ApiDiagnosticOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (diagnosticId == null)
             {

diff --git a/...nt/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiIssueAttachmentOperations.cs b/...nt/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiIssueAttachmentOperations.cs
@@ -131,10 +131,6 @@ internal ApiIssueAttachmentOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {
@@ -397,10 +393,6 @@ internal ApiIssueAttachmentOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {
@@ -673,10 +665,6 @@ internal ApiIssueAttachmentOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {
@@ -974,10 +962,6 @@ internal ApiIssueAttachmentOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {
@@ -1311,10 +1295,6 @@ internal ApiIssueAttachmentOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {

diff --git a/...ement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiIssueCommentOperations.cs b/...ement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiIssueCommentOperations.cs
@@ -131,10 +131,6 @@ internal ApiIssueCommentOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {
@@ -397,10 +393,6 @@ internal ApiIssueCommentOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {
@@ -673,10 +665,6 @@ internal ApiIssueCommentOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {
@@ -973,10 +961,6 @@ internal ApiIssueCommentOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {
@@ -1310,10 +1294,6 @@ internal ApiIssueCommentOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {

diff --git a/...pimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiIssueOperations.cs b/...pimanagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiIssueOperations.cs
@@ -130,10 +130,6 @@ internal ApiIssueOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (Client.ApiVersion == null)
             {
@@ -377,10 +373,6 @@ internal ApiIssueOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {
@@ -631,10 +623,6 @@ internal ApiIssueOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {
@@ -912,10 +900,6 @@ internal ApiIssueOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {
@@ -1228,10 +1212,6 @@ internal ApiIssueOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {
@@ -1492,10 +1472,6 @@ internal ApiIssueOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (issueId == null)
             {

diff --git a/...nagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiOperationOperations.cs b/...nagement/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiOperationOperations.cs
@@ -398,10 +398,6 @@ internal ApiOperationOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
-                }
             }
             if (Client.ApiVersion == null)
             {
@@ -650,10 +646,6 @@ internal ApiOperationOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
-                }
             }
             if (Client.ApiVersion == null)
             {
@@ -927,10 +919,6 @@ internal ApiOperationOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
-                }
             }
             if (parameters == null)
             {
@@ -1245,10 +1233,6 @@ internal ApiOperationOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
-                }
             }
             if (parameters == null)
             {
@@ -1510,10 +1494,6 @@ internal ApiOperationOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
-                }
             }
             if (ifMatch == null)
             {

diff --git a/...nt/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiOperationPolicyOperations.cs b/...nt/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiOperationPolicyOperations.cs
@@ -147,10 +147,6 @@ internal ApiOperationPolicyOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
-                }
             }
             if (Client.ApiVersion == null)
             {
@@ -402,10 +398,6 @@ internal ApiOperationPolicyOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
-                }
             }
             if (Client.ApiVersion == null)
             {
@@ -660,10 +652,6 @@ internal ApiOperationPolicyOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
-                }
             }
             if (Client.ApiVersion == null)
             {
@@ -945,10 +933,6 @@ internal ApiOperationPolicyOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
-                }
             }
             if (parameters == null)
             {
@@ -1262,10 +1246,6 @@ internal ApiOperationPolicyOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "operationId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(operationId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "operationId", "^[^*#&+:<>?]+$");
-                }
             }
             if (ifMatch == null)
             {

diff --git a/...management/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiProductOperations.cs b/...management/Microsoft.Azure.Management.ApiManagement/src/Generated/ApiProductOperations.cs
@@ -127,10 +127,6 @@ internal ApiProductOperations(ApiManagementClient client)
                 {
                     throw new ValidationException(ValidationRules.MinLength, "apiId", 1);
                 }
-                if (!System.Text.RegularExpressions.Regex.IsMatch(apiId, "^[^*#&+:<>?]+$"))
-                {
-                    throw new ValidationException(ValidationRules.Pattern, "apiId", "^[^*#&+:<>?]+$");
-                }
             }
             if (Client.ApiVersion == null)
             {