Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript script errors for uninitialised private properties. #700

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Fix typescript script errors for uninitialised private properties. #700

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a486a10
Fix typescript script errors for uninitialised private properties.
paulferrett Feb 17, 2023
5a8b81d
Fix for default value for `_isEmpty`.
paulferrett Feb 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/js/signature_pad.umd.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions src/signature_pad.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,12 @@ export default class SignaturePad extends SignatureEventTarget {
// Private stuff
/* tslint:disable: variable-name */
private _ctx: CanvasRenderingContext2D;
private _drawningStroke: boolean;
private _isEmpty: boolean;
private _lastPoints: Point[]; // Stores up to 4 most recent points; used to generate a new curve
private _data: PointGroup[]; // Stores all points in groups (one group per line or dot)
private _lastVelocity: number;
private _lastWidth: number;
private _drawningStroke = false;
private _isEmpty = false;
paulferrett marked this conversation as resolved.
Show resolved Hide resolved
private _lastPoints: Point[] = []; // Stores up to 4 most recent points; used to generate a new curve
private _data: PointGroup[] = []; // Stores all points in groups (one group per line or dot)
private _lastVelocity = 0;
private _lastWidth = 0;
private _strokeMoveUpdate: (event: SignatureEvent) => void;
/* tslint:enable: variable-name */

Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
"strictNullChecks": true,
"strictFunctionTypes": true,
"alwaysStrict": true,
"strict": true,

"removeComments": true,
"newLine": "LF",
Expand Down