Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render application templates #45

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Render application templates #45

merged 1 commit into from
Mar 4, 2024

Conversation

dontub
Copy link
Collaborator

@dontub dontub commented Feb 22, 2024

Corresponds to systopia/funding#223.

This approach uses a custom subclass of Drupal\views\Plugin\views\field\Dropbutton that is injected in the relevant views via civiremote_funding_views_pre_build() hook. The drop button adds links for the respective templates.

systopia-reference: 23716

@dontub dontub requested a review from jensschuppe February 22, 2024 15:15
Copy link
Contributor

@jensschuppe jensschuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can see this is silently adding to the link list of a Views field named dropbutton if it is a regular Dropbutton, for two specific views identified by name. This should be documented somewhere visible in the Views UI, e.g. in the administrative title of that dropbutton field or as a description in its configuration form. This might confuse site builders otherwise …

@dontub
Copy link
Collaborator Author

dontub commented Feb 26, 2024

This should be documented somewhere visible in the Views UI, e.g. in the administrative title of that dropbutton field or as a description in its configuration form.

I've added a note to the administrative title.

@dontub dontub force-pushed the application-template-render branch from 2534f9b to e768cdb Compare March 4, 2024 08:25
@dontub dontub merged commit f8836b3 into main Mar 4, 2024
@dontub dontub deleted the application-template-render branch March 4, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants