Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormResponseHandlerAction does not use proper dependency #39

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

tobiasbaehr
Copy link
Contributor

TypeError: Drupal\civiremote_funding\Form\ResponseHandler\FormResponseHandlerAction::__construct(): Argument #2 ($requestStack) must be of type Drupal\Core\Http\RequestStack, Symfony\Component\HttpFoundation\RequestStack given, called in /app/code/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\civiremote_funding\Form\ResponseHandler\FormResponseHandlerAction->__construct() (line 39 of modules/custom/civiremote_funding/src/Form/ResponseHandler/FormResponseHandlerAction.php).

@dontub
Copy link
Collaborator

dontub commented Jan 3, 2024

Thanks for the PR! Can you also update FormResponseHandlerActionTest?

@BrutalBirdie
Copy link

fyi: @tobiasbaehr will be available again on the 15.01.2024 so this issue will gather some dust until the :)

…mponent\HttpFoundation\RequestStack

TypeError: Drupal\civiremote_funding\Form\ResponseHandler\FormResponseHandlerAction::__construct(): Argument systopia#2 ($requestStack) must be of type Drupal\Core\Http\RequestStack, Symfony\Component\HttpFoundation\RequestStack given, called in /app/code/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\civiremote_funding\Form\ResponseHandler\FormResponseHandlerAction->__construct() (line 39 of modules/custom/civiremote_funding/src/Form/ResponseHandler/FormResponseHandlerAction.php).
@dontub dontub force-pushed the tobiasbaehr-patch-1 branch from c7db7d5 to 887fcd6 Compare January 3, 2024 15:23
@dontub
Copy link
Collaborator

dontub commented Jan 3, 2024

Thanks for the info. I've modified the PR myself now.

@dontub dontub merged commit df74cf0 into systopia:main Jan 3, 2024
@dontub dontub added bug Something isn't working fixed Issue has been fixed labels Jan 3, 2024
@tobiasbaehr tobiasbaehr deleted the tobiasbaehr-patch-1 branch January 3, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Issue has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants