feat(sdf): Add ability to set a module as private when contributing #5614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-sdf
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
stack72
force-pushed
the
private-scoped-modules
branch
3 times, most recently
from
19f4c64 to
7732982
Compare
stack72
commented
Mar 6, 2025
|
|
||
| // TO-DO: Paul | ||
| // I will refactor this + insert together - this is to temporarily get something working | ||
| async fn insert_private_module( |
There was a problem hiding this comment.
I have done this on purpose for now - I am testing the viability of this and don't want to break any of the existing routes rigth now - I will refactor this + insert into a single function
stack72
force-pushed
the
private-scoped-modules
branch
from
7732982 to
53e10f5
Compare
|
/try |
|
Okay, starting a try! I'll update this comment once it's running...\n |
stack72
force-pushed
the
private-scoped-modules
branch
from
53e10f5 to
caecab5
Compare
stack72
force-pushed
the
private-scoped-modules
branch
from
caecab5 to
bf2857b
Compare
stack72
force-pushed
the
private-scoped-modules
branch
from
bf2857b to
56f0f88
Compare
This means that when we won't show this module in module listings and it will be available for you on all workspaces you log into
stack72
force-pushed
the
private-scoped-modules
branch
from
56f0f88 to
41e8928
Compare
|
/try |
|
Okay, starting a try! I'll update this comment once it's running...\n |
|
/try |
|
Okay, starting a try! I'll update this comment once it's running...\n |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that when we won't show this module in module listings and it will be available for you on all workspaces you log into
This is feature flagged and will not yet be available to users