feat(clover): add Joi validations #5469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Joi validations for scalars:
It does this by:
Joi.string().max(255).pattern(new RegExp("^arn:"))
) based on the type and validation criteria on the property. If there are no modifiers besides the type (like string / number / boolean), validation is not generated. This is stuffed in prop.joiValidation, which will be used by the asset function generator later.eval()
, callingdescribe()
on the resulting Joi object and encoding that to JSON before putting it into package spec format.setValidationFormat(<prop.joiValidation>)
builder call to the PropBuilder, and prop.joiValidation is deleted to make sure we don't dump it unnecessarily into the PkgSpec we upload.Testing