Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hoist, module-index-server): Adding a new upsert_builtin endpoint #5464

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Feb 12, 2025

Hoist was calling 3 API endpoints in an unsafe manner - now we wrap all of those into a new endpoint that has a transaction when we know it's successful

Copy link

github-actions bot commented Feb 12, 2025

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@stack72 stack72 force-pushed the upsert_builtin_route branch from fb7cc47 to 747364f Compare February 12, 2025 21:05
Copy link
Contributor

@vbustamante vbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@stack72 stack72 added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2025
@stack72 stack72 added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2025
@stack72 stack72 added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2025
@stack72 stack72 added this pull request to the merge queue Feb 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 12, 2025
@stack72 stack72 added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
Hoist was calling 3 API endpoints in an unsafe manner - now we wrap all of those into a new endpoint that has a transaction when we know it's successful
@stack72 stack72 force-pushed the upsert_builtin_route branch from 747364f to 88fe5c5 Compare February 13, 2025 00:48
@stack72 stack72 added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@stack72 stack72 added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 14a586d Feb 13, 2025
9 checks passed
@stack72 stack72 deleted the upsert_builtin_route branch February 13, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants