feat: delete components from management functions #5215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-sdf
Dependency Review✅ No vulnerabilities or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
zacharyhamm
force-pushed
the
zack/mgmt-fns-can-delete-components-and-views
branch
from
b14e519 to
63c082a
Compare
|
This PR refactors deletion so that the management function and the delete components endpoint use mostly the same code. To test it one should delete and erase a combination of components on head, not on head, with and without resources to see if they delete properly |
Components managed by a management component can now be deleted in a management func. Two new properties have been added to the ops return value: `delete?: string[]` and `erase?: string[]`. Delete will mark components with resources as to_delete, while erase will delete components regardless of their resource status. Components to delete or erase can be specified either by their name, or their id (available on the components input array). id will be more reliable if there is more than one managed component with the same name.
zacharyhamm
force-pushed
the
zack/mgmt-fns-can-delete-components-and-views
branch
from
63c082a to
aec717c
Compare
jobelenus
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Components managed by a management component can now be deleted in a management func. Two new properties have been added to the ops return value:
delete?: string[]anderase?: string[]. Delete will mark components with resources as to_delete, while erase will delete components regardless of their resource status. Components to delete or erase can be specified either by their name, or their id (available on the components input array). id will be more reliable if there is more than one managed component with the same name.