chore(forklift): add tuning for concurrent audit log database inserts #5044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a tunable in forklift's configuration called `insert_concurrency_limit` to control how many concurrent inserts are running. This can be set in a `forklift.toml` with: ```toml [audit] insert_concurrency_limit = 4 ``` Or in an environment variable with: ```sh SI_FORKLIFT__AUDIT__INSERT_CONCURRENCY_LIMIT=4 ``` Longer term, each microservice that forklift runs should have its own tunable for its own concurrency as one broad brush stroke won't be sufficient in the various environments. Additionally the name for the idea of a concurrency limit has `insert_` in it because currently we render the exact same `config.toml` template in all environments and for all services. This is one way for the moment to be very clear as to what this tunes (as read from a more "global" context). Signed-off-by: Fletcher Nichol <[email protected]>
vbustamante
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a tunable in forklift's configuration called
insert_concurrency_limitto control how many concurrent inserts are running.This can be set in a
forklift.tomlwith:Or in an environment variable with:
Longer term, each microservice that forklift runs should have its own tunable for its own concurrency as one broad brush stroke won't be sufficient in the various environments. Additionally the name for the idea of a concurrency limit has
insert_in it because currently we render the exact sameconfig.tomltemplate in all environments and for all services. This is one way for the moment to be very clear as to what this tunes (as read from a more "global" context).