Add custom extractor for filtering audit logs #4829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-si-settings
nickgerace
force-pushed
the
nick/eng-2751
branch
from
879ee5f to
74be2ac
Compare
nickgerace
commented
Oct 21, 2024
Comment on lines
150
to
151
| let perms = Permission::new(workspace_object.clone(), "approve", user_object.clone()); | ||
| let bad_perms = Permission::new(workspace_object, "approve", user_object2); |
zacharyhamm
reviewed
Oct 21, 2024
lib/sdf-server/src/extract.rs
Outdated
| .uri | ||
| .query() | ||
| .ok_or(not_found_error("no query string found in uri"))?; | ||
| let deserialized = serde_qs::from_str(query).map_err(|err| internal_error(err))?; |
There was a problem hiding this comment.
I mean: shouldn't this produce a 422 and not a 500? If we fail to deserialize it's because the input was invalid
There was a problem hiding this comment.
Same with the not found. That's invalid input, not a resource not found
There was a problem hiding this comment.
Ah fair point. Will fix
There was a problem hiding this comment.
(or maybe 400: Bad Request)
nickgerace
force-pushed
the
nick/eng-2751
branch
from
74be2ac to
7360df4
Compare
nickgerace
force-pushed
the
nick/eng-2751
branch
from
7360df4 to
72e7c37
Compare
zacharyhamm
previously approved these changes
Oct 21, 2024
nickgerace
force-pushed
the
nick/eng-2751
branch
from
72e7c37 to
671295a
Compare
zacharyhamm
previously approved these changes
Oct 21, 2024
This commit adds a custom extractor for filtering audit logs. Generally, it handles array notated query string parameters, which is likely the first time we needed to do so in sdf. Signed-off-by: Nick Gerace <[email protected]>
nickgerace
force-pushed
the
nick/eng-2751
branch
from
671295a to
b7b2611
Compare
zacharyhamm
approved these changes
Oct 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a custom extractor for filtering audit logs. Generally, it handles array notated query string parameters, which is likely the first time we needed to do so in
sdf.