updating vue/vite deps #3080
Merged
updating vue/vite deps #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theoephraim
commented
Dec 19, 2023
| @@ -103,7 +103,7 @@ | |||
| variant="transparent" | |||
| tone="shade" | |||
| @mousedown.prevent | |||
| @click.prevent="profileMenuRef?.open" | |||
| @click.prevent="profileMenuRef?.open || _.noop" | |||
There was a problem hiding this comment.
shouldnt really need this but it was causing a vue internals bug... I expect it to be fixed pretty quickly.
There was a problem hiding this comment.
looks like the issue itself is resolved but we'll need to wait for a few dependencies to update to the latest vue (not just us)
theoephraim
force-pushed
the
theo/vite-cache-issues
branch
from
79a9e6b
to
1ec9fc0
Compare
theoephraim
force-pushed
the
theo/vite-cache-issues
branch
from
1ec9fc0
to
c51ade1
Compare
|
bors merge |
si-bors-ng bot
added a commit
that referenced
this pull request
Dec 19, 2023
3080: updating vue/vite deps r=theoephraim a=theoephraim encountering a vite issue lately that requires clearing the cache to unstick your local env... No idea if this will fix it as we dont have clear reproduction steps, but this should hopefully help. Co-authored-by: Theo Ephraim <[email protected]>
|
Build failed: |
|
bors merge |
si-bors-ng bot
added a commit
that referenced
this pull request
Dec 19, 2023
3080: updating vue/vite deps r=theoephraim a=theoephraim encountering a vite issue lately that requires clearing the cache to unstick your local env... No idea if this will fix it as we dont have clear reproduction steps, but this should hopefully help. Co-authored-by: Theo Ephraim <[email protected]>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encountering a vite issue lately that requires clearing the cache to unstick your local env...
No idea if this will fix it as we dont have clear reproduction steps, but this should hopefully help.