Several required fixes for the WebInterfacePlugin
#4392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid double-free were taking place during plugin de-initialization due to ODR violations motivated by these objects. Simplest solution is making them not require 'allocation/deallocation'.
Previously 'libhttpserver' only exposed method 'get_path_pieces()', this method makes use of the internal 'standardized_url' for tokenizing the URL. This method has the limitation of performing the escaping prior to the tokenization of elements, incurring into improper tokenization. The new introduced function 'get_url_pieces()' corrects this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several minor fixes to ProxySQL itself, and some required changes to
libhttpserverdependency, a brief summary:libhttpserverwhen URL contains characters that are required to be escaped.static globalvariables onlibhttpserver.