Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several queries not disabling multiplexing for STMT_EXECUTE #3970

Merged
merged 4 commits into from
Sep 14, 2022

Conversation

JavierJF
Copy link
Collaborator

@JavierJF JavierJF commented Sep 9, 2022

This PR addresses two different issues:

  1. Queries that are supposed to flag a connection with different status were not taking effect when a prepared statement was already cached. This is solved by forcing the re-evaluation of the query digest for the statement each time during STMT_EXECUTE. This solution involves re-computation, an alternative design (or inspiration for a future design) is left in this PR as a form of patch. This alternative design would make use of the 'stmt cache' itself for storing the status_flags that are required to be imposed to the future connection that is performing the STMT_EXECUTE, thus avoiding the need of recompute.
  2. Fix a crash that takes place when the connection used for a request that should be logged is tried to be reset, and the CHANGE_USER for this reset operations fails.

stmt_cache_conn_status.patch.zip

@mirostauder
Copy link
Collaborator

retest this please

4 similar comments
@mirostauder
Copy link
Collaborator

retest this please

@renecannao
Copy link
Contributor

retest this please

@renecannao
Copy link
Contributor

retest this please

@renecannao
Copy link
Contributor

retest this please

@renecannao renecannao merged commit 8c48b37 into v2.x Sep 14, 2022
@renecannao renecannao deleted the v2.x-stmt_execute_conn_status branch January 11, 2023 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants