Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2.x php no backslash escapes (PHP bug66141) #3854

Merged
merged 2 commits into from
Apr 27, 2022
Merged

V2.x php no backslash escapes (PHP bug66141) #3854

merged 2 commits into from
Apr 27, 2022

Conversation

renecannao
Copy link
Contributor

Track NO_BACKSLASH_ESCAPES in case it is changed:

  • using SET sql_mode by the client
  • directly on the backend (for example default sql_mode, or an sql_mode set from another variable)

No TAP test provided because we will be using PHP tests

@renecannao
Removed reference to STATUS_MYSQL_CONNECTION_NO_BACKSLASH_ESCAPES
50f1c9f 
STATUS_MYSQL_CONNECTION_NO_BACKSLASH_ESCAPES was an internal status in
ProxySQL , now deprecated
@renecannao
Track NO_BACKSLASH_ESCAPES
9275e28 
Track NO_BACKSLASH_ESCAPES in case it is changed:
- using SET sql_mode by the client
- directly on the backend (for example default sql_mode, or an
  sql_mode set from another variable)
@mirostauder
Copy link
Collaborator

This is a fix for FAIL on PHP test
php-src/ext/pdo_mysql/tests/bug66141.phpt

@mirostauder
Copy link
Collaborator 

=====================================================================
Running selected tests.
PASS Bug #66141 (mysqlnd quote function is wrong with NO_BACKSLASH_ESCAPES after failed query) [ext/pdo_mysql/tests/bug66141.phpt] 
=====================================================================
Number of tests :    1                 1
Tests skipped   :    0 (  0.0%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    0 (  0.0%) (  0.0%)
Tests passed    :    1 (100.0%) (100.0%)
---------------------------------------------------------------------
Time taken      :    0 seconds
=====================================================================

@renecannao renecannao changed the title V2.x php no backslash escapes V2.x php no backslash escapes (PHP bug66141) Apr 27, 2022
@renecannao
Copy link
Contributor Author

For reference:
https://github.com/php/php-src/blob/master/ext/pdo_mysql/tests/bug66141.phpt

@renecannao renecannao merged commit f36b283 into v2.x Apr 27, 2022
@renecannao renecannao deleted the v2.x-php_NO_BACKSLASH_ESCAPES branch April 30, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@renecannao @mirostauder