Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL_Connection::MultiplexDisabled() should return true also if SERVER_STATUS_IN_TRANS is enabled #4241

Closed
renecannao opened this issue Jun 6, 2023 · 0 comments · Fixed by #4430
Closed

MySQL_Connection::MultiplexDisabled() should return true also if SERVER_STATUS_IN_TRANS is enabled #4241

renecannao opened this issue Jun 6, 2023 · 0 comments · Fixed by #4430

Comments

@renecannao
Copy link
Contributor

renecannao commented Jun 6, 2023 •
edited
Loading

Currently MySQL_Connection::MultiplexDisabled() returns true if any variable of an internal set of variables is enabled, or if auto_increment_delay_token is evaluated.

We should also evaluate SERVER_STATUS_IN_TRANS in the backend connection, and last_errno .
Probably we can just call IsActiveTransaction() .

This will make troubleshooting easier.

Note: we should also remove any reference to STATUS_MYSQL_CONNECTION_TRANSACTION as it is deprecated.
renecannao added a commit that referenced this issue Jan 18, 2024
@renecannao
Added metric MultiplexDisabled_ext #4241
41cd740 
In the output of PROXYSQL INTERNAL SESSION and stats_mysql_processlist.extended_info ,
MultiplexDisabled was only returning the output of MySQL_Connection::MultiplexDisabled() .
If there was a transaction, or an error, multiplexing was disabled but MultiplexDisabled() was
still reporting false. Therefore it was necessary to also check server_status flag and last_errno.
This commits intruduces MultiplexDisabled_ext , that reports the output of:
MySQL_Connection::MultiplexDisabled() || MySQL_Connection::isActiveTransaction()

This should make troubleshooting easier.

Also, removed any reference to deprecated STATUS_MYSQL_CONNECTION_TRANSACTION .

Closes #4241
@renecannao renecannao mentioned this issue Jan 18, 2024
Merged
renecannao added a commit that referenced this issue Jan 19, 2024
@renecannao
Merge pull request #4430 from sysown/v2.x-4241
7f57f20 
Added metric MultiplexDisabled_ext #4241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added metric MultiplexDisabled_ext #4241 sysown/proxysql
1 participant
@renecannao