Skip to content

Commit

Permalink
Added a TODO comment for a future removal of tracked variable 'SQL_CH…
Browse files Browse the repository at this point in the history
…ARACTER_SET_DATABASE' #2021
  • Loading branch information
JavierJF committed Dec 2, 2021
1 parent 6188f91 commit b9a1594
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions include/proxysql_structs.h
Original file line number Diff line number Diff line change
Expand Up @@ -1053,6 +1053,9 @@ typedef struct {
char * default_value; // default value
bool is_global_variable; // is it a global variable?
} mysql_variable_st;
TODO: 'SQL_CHARACTER_SET_DATABASE' is a variable that shouldn't be set, or tracked on our side, since it's meant to be only updated by the server:
- https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_character_set_database
*/
mysql_variable_st mysql_tracked_variables[] {
{ SQL_CHARACTER_SET, SETTING_CHARSET, false, true, false, false, false, (char *)"charset", (char *)"charset", (char *)"utf8" , true} , // should be before SQL_CHARACTER_SET_RESULTS
Expand Down

0 comments on commit b9a1594

Please sign in to comment.