stats: deindex pruned counters/clusters #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Szakacs <[email protected]>
Dynamic counters were freed after they became expired, but they stayed in the `counter_index`, which is used for `get` queries. When we tried to access these freed counters from the index, we got undefined behavior, possibly SEGFAULT. Signed-off-by: Attila Szakacs <[email protected]>
|
Build SUCCESS |
lbudai
approved these changes
Mar 26, 2019
MrAnno
approved these changes
Mar 26, 2019
|
Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic counters/clusters were freed after they became expired, but they stayed in the
counter_index, which is used forgetqueries. When we tried to access these freed counters from the index, we got undefined behavior, possibly SEGFAULT.Signed-off-by: Attila Szakacs [email protected]