tls: disable ssl compression by default #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build SUCCESS |
|
I am yet to be convinced that CRIME applies to syslog, and at one point it
was explicitly requested to allow compression in one way or the other, and
ssl was the solution.
So in what way are we vulnerable to crime? And can you point me how this
was fixed in openssl in distros? I would even argue to make it possible to
enable compression even if its disabled by default.
Ssl is not just for http.
Bazsi
…On Wed, Oct 24, 2018, 17:17 furiel ***@***.***> wrote:
Currently syslog-ng does not change the tls compression setting of tls
transport. This means the default setting depends on the patch level and
compile options of openssl. However the default compression setting should
be disabled by default to avoid CRIME vulnerability.
This patchset explicitely disables tls compression to be sure.
This PR has minor impact: distributions typically provide non-vulnerable
openssl binaries.
------------------------------
You can view, comment on, or merge this pull request online at:
#2372
Commit Summary
- tlscontext: compression setting function made to public
- transport-mapper-inet: disable tls compression
File Changes
- *M* lib/tlscontext.c
<https://github.com/balabit/syslog-ng/pull/2372/files#diff-0> (13)
- *M* lib/tlscontext.h
<https://github.com/balabit/syslog-ng/pull/2372/files#diff-1> (1)
- *M* lib/transport/transport-factory-tls.c
<https://github.com/balabit/syslog-ng/pull/2372/files#diff-2> (16)
- *M* modules/afsocket/transport-mapper-inet.c
<https://github.com/balabit/syslog-ng/pull/2372/files#diff-3> (1)
Patch Links:
- https://github.com/balabit/syslog-ng/pull/2372.patch
- https://github.com/balabit/syslog-ng/pull/2372.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2372>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AArldjfef73tXBCTnrqdw4sYW7QDVikbks5uoISMgaJpZM4X4Kf8>
.
|
|
@bazsi : |
furiel
changed the title
|
Build SUCCESS |
|
@kira-syslogng test this please test branch=micek_allow_compress; |
|
Build SUCCESS |
1 similar comment
|
Build SUCCESS |
|
Build SUCCESS |
|
Build SUCCESS |
|
Build SUCCESS |
furiel
changed the title
lbudai
reviewed
Nov 26, 2018
|
Build SUCCESS |
Signed-off-by: Antal Nemes <[email protected]>
Signed-off-by: Antal Nemes <[email protected]>
Signed-off-by: Antal Nemes <[email protected]>
Signed-off-by: Antal Nemes <[email protected]>
|
Build SUCCESS |
lbudai
approved these changes
Nov 27, 2018
Kokan
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently syslog-ng does not change the tls compression setting of tls transport. This means the default setting depends on the patch level and compile options of openssl. H̶o̶w̶e̶v̶e̶r̶ ̶t̶h̶e̶ ̶d̶e̶f̶a̶u̶l̶t̶ ̶c̶o̶m̶p̶r̶e̶s̶s̶i̶o̶n̶ ̶s̶e̶t̶t̶i̶n̶g̶ ̶s̶h̶o̶u̶l̶d̶ ̶b̶e̶ ̶d̶i̶s̶a̶b̶l̶e̶d̶ ̶b̶y̶ ̶d̶e̶f̶a̶u̶l̶t̶ ̶t̶o̶ ̶a̶v̶o̶i̶d̶ ̶C̶R̶I̶M̶E̶ ̶v̶u̶l̶n̶e̶r̶a̶b̶i̶l̶i̶t̶y̶.̶ Edit: syslog-ng is not vulnerable to CRIME.
T̶h̶i̶s̶ ̶p̶a̶t̶c̶h̶s̶e̶t̶ ̶e̶x̶p̶l̶i̶c̶i̶t̶e̶l̶y̶ ̶d̶i̶s̶a̶b̶l̶e̶s̶ ̶t̶l̶s̶ ̶c̶o̶m̶p̶r̶e̶s̶s̶i̶o̶n̶ ̶t̶o̶ ̶b̶e̶ ̶s̶u̶r̶e̶.̶
This patchset makes tls compression configurable, with disabled by default.
Note: allow-compress(yes) does not necessarily mean the session will be compressed. It only means endpoints are allowed to choose tls compression during negotiation. For example if the openssl is compiled without zlib either on the local or the remote side, compression will not happen.