Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor widget hints so that DataGridField works #143

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Honor widget hints so that DataGridField works #143

merged 1 commit into from
Jan 24, 2024

Conversation

reinhardt
Copy link
Contributor

syslabcom/scrum#1199

@reinhardt reinhardt requested a review from thet January 24, 2024 12:28
thet
thet approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@thet thet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Is this fixing a general problem which also affects any datagridfield installation?

@reinhardt
Copy link
Contributor Author

Is this fixing a general problem which also affects any datagridfield installation?

Only if you do funky stuff in the default view like we do here.

@reinhardt reinhardt merged commit 48f0840 into main Jan 24, 2024
3 checks passed
@reinhardt reinhardt deleted the scrum-1199-data-grid branch January 24, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thet thet thet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reinhardt @thet