Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: there should be only one exit event #57

Merged
merged 1 commit into from
May 18, 2023
Merged

Conversation

metakot
Copy link
Contributor

@metakot metakot commented May 15, 2023

So AppStatus.should_exit_event got rewrited in listen_for_exit_signal with every new connection being made and old connections remain in connected state when server stops.
This fixes that.

@sysid
Copy link
Owner

sysid commented May 18, 2023

Nicely spotted @metakot, thank you !

@sysid sysid merged commit e996a9f into sysid:master May 18, 2023
@sysid
Copy link
Owner

sysid commented May 18, 2023

Problem is: Parametrized tests are failing now with:
RuntimeError: <asyncio.locks.Event object at 0x1046a0a30 [unset]> is bound to a different event loop

I fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants