🐛 Increase timeout on connection refused errors #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syself-bot
bot
added
size/S
We have the timeout of one minute that we allow connection refused errors to come after reboot of a server. In this commit we added the (correct) permanent error if we conclude the reboot to be "failed". However, apparently, for a long time already, we marked reboots as failed that did not actually fail. This commit introduces a larger timeout, so that we don't mark the reboots as failed, and in turn don't mark the HetznerBareMetalHost as failed. We also increase the timeouts to a minimum of 10 min, so that we don't run into failed states so quickly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We have the timeout of one minute that we allow connection refused errors to come after reboot of a server.
In this commit we added the (correct) permanent error if we conclude the reboot to be "failed". However, apparently, for a long time already, we marked reboots as failed that did not actually fail.
This commit introduces a larger timeout, so that we don't mark the reboots as failed, and in turn don't mark the HetznerBareMetalHost as failed.
TODOs: