Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Avoid misleading error logs when deleting hbmh #1346

Merged
merged 1 commit into from
Jun 18, 2024
Merged

🌱 Avoid misleading error logs when deleting hbmh #1346

merged 1 commit into from
Jun 18, 2024

Conversation

guettli
Copy link
Collaborator

@guettli guettli commented Jun 17, 2024

What this PR does / why we need it:

Requeue after Deleting, and better log-message if HetznerCluster name is empty.

@guettli guettli requested a review from janiskemper June 17, 2024 10:39
janiskemper
janiskemper approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@janiskemper janiskemper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, but plz update your PR description. This sounds a bit too much right now.

"Avoid misleading error logs when deleting hbmh" sounds more appropriate IMO

@guettli guettli marked this pull request as ready for review June 17, 2024 11:49
@syself-bot syself-bot bot added the area/code Changes made in the code directory label Jun 17, 2024
@guettli guettli changed the title 🌱 Fix deleting of hbmh 🌱 Avoid misleading error logs when deleting hbmh Jun 17, 2024
@janiskemper janiskemper merged commit d26d0d7 into main Jun 18, 2024
19 checks passed
@janiskemper janiskemper deleted the tg/fix-deleting-of-hbmh branch June 18, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janiskemper janiskemper janiskemper approved these changes

Assignees
No one assigned
Labels
area/code Changes made in the code directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guettli @janiskemper