✨ Add ssh key name via hetzner secret #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guettli
reviewed
May 2, 2024
guettli
reviewed
May 2, 2024
guettli
reviewed
May 2, 2024
Adding the ssh key name via hetzner secret facilitates use cases where a lot of clusters are created with the same ssh key. Instead of having to specify it every time in the HetznerClusterTemplate object, it can be specified in the secret ones. On top, this commit introduces default values for the HetznerSecret to allow use cases where all is hard-coded and doesn't have to be specified e.g. in a ClusterClass or in the templates of the cluster object anymore.
syself-bot
bot
added
area/code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding the ssh key name via hetzner secret facilitates use cases where a lot of clusters are created with the same ssh key. Instead of having to specify it every time in the HetznerClusterTemplate object, it can be specified in the secret ones.
On top, this commit introduces default values for the HetznerSecret to allow use cases where all is hard-coded and doesn't have to be specified e.g. in a ClusterClass or in the templates of the cluster object anymore.
TODOs: