✨ Add constant hostnames to bare metal servers #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guettli
reviewed
Apr 30, 2024
guettli
requested changes
Apr 30, 2024
guettli
approved these changes
May 2, 2024
Adding the feature to keep hostnames of bare metal servers constant. This can be triggered by a feature flag on the Cluster object. It takes the usual "bm-" prefix together with the cluster name as well as the serverID of the bare metal server.
syself-bot
bot
added
area/code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adding the feature to keep hostnames of bare metal servers constant. This can be triggered by a feature flag on the Cluster object. It takes the usual "bm-" prefix together with the cluster name as well as the serverID of the bare metal server.
This feature can be used by adding the annotation
"capi.syself.com/constant-bare-metal-hostname": "true"toClusterobjects.TODOs: