Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 log name of server and lb #1242

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

kranurag7
Copy link
Contributor

till now we only used numeric ID in logs which becomes sometimes hard during debugging as things needs to cross checked.

@kranurag7 kranurag7 requested review from janiskemper and guettli April 2, 2024 18:39
Copy link
Collaborator

@guettli guettli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would avoid %v and use the formatting which is matching to the type.

The %v was in the old code. But if you change the line, I would change that, too.

@kranurag7 kranurag7 force-pushed the kr/use-server-name-in-logs branch from 1fc5069 to e5dcbb7 Compare April 3, 2024 09:07
till now we only used numeric ID in logs which becomes sometimes hard
during debugging as things needs to cross checked.

Signed-off-by: kranurag7 <[email protected]>
@kranurag7 kranurag7 force-pushed the kr/use-server-name-in-logs branch from e5dcbb7 to 955f68d Compare April 3, 2024 10:14
@kranurag7 kranurag7 marked this pull request as ready for review April 3, 2024 10:43
@syself-bot syself-bot bot added the area/code Changes made in the code directory label Apr 3, 2024
@kranurag7 kranurag7 merged commit a5e6a12 into main Apr 3, 2024
14 checks passed
@kranurag7 kranurag7 deleted the kr/use-server-name-in-logs branch April 3, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Changes made in the code directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants