🐛 Add servers to LB only after API server ready #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batistein
force-pushed
the
lr/add-only-ready-servers-to-lb
branch
from
0738ded to
cc1d773
Compare
batistein
force-pushed
the
lr/add-only-ready-servers-to-lb
branch
from
cc1d773 to
65fee9a
Compare
lucasrattz
force-pushed
the
lr/add-only-ready-servers-to-lb
branch
2 times, most recently
from
8e61469 to
ae2b472
Compare
batistein
force-pushed
the
lr/add-only-ready-servers-to-lb
branch
from
ae2b472 to
db9aa80
Compare
syself-bot
bot
added
the
size/M
lucasrattz
force-pushed
the
lr/add-only-ready-servers-to-lb
branch
2 times, most recently
from
bb83505 to
3a4543b
Compare
lucasrattz
force-pushed
the
lr/add-only-ready-servers-to-lb
branch
from
3a4543b to
fb13292
Compare
janiskemper
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR aims to improve the addition of servers to the load balancer, avoiding downtime by adding them only after the API server pod is healthy.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1148
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Unit tests will be added later.
TODOs: