Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 update python shebang to python3 #1144

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

rpahli
Copy link
Contributor

@rpahli rpahli commented Feb 5, 2024

What this PR does / why we need it:

this PR updates the python shebang to python3 to work with distos which have no python symlink.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1142

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@janiskemper janiskemper requested a review from kranurag7 February 5, 2024 15:28
@kranurag7 kranurag7 marked this pull request as ready for review February 5, 2024 15:52
@syself-bot syself-bot bot added the area/hack Changes made in the hack directory label Feb 5, 2024
Copy link
Contributor

@kranurag7 kranurag7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much @rpahli

@kranurag7 kranurag7 merged commit 8ee5d9b into syself:main Feb 5, 2024
2 checks passed
@rpahli rpahli deleted the python3 branch February 5, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hack Changes made in the hack directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch to python3
2 participants