Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add event if host is provisioned #1045

Merged
merged 1 commit into from
Nov 10, 2023
Merged

🌱 Add event if host is provisioned #1045

merged 1 commit into from
Nov 10, 2023

Conversation

janiskemper
Copy link
Contributor

What this PR does / why we need it:
Adding an event to show that the provisioning process has been completed. This is important to find out based on events where an issue happens. Even if it is successfully provisioned, it might not be added to the cluster, as the CCM does some work after CAPH. To know more about the state, this event will be helpful.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

Adding an event to show that the provisioning process has been
completed. This is important to find out based on events where an issue
happens. Even if it is successfully provisioned, it might not be added
to the cluster, as the CCM does some work after CAPH. To know more about
the state, this event will be helpful.
Copy link
Collaborator

@guettli guettli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@janiskemper janiskemper marked this pull request as ready for review November 6, 2023 15:21
@syself-bot syself-bot bot added the area/code Changes made in the code directory label Nov 6, 2023
@batistein batistein merged commit ce3b659 into main Nov 10, 2023
14 checks passed
@batistein batistein deleted the provision-event branch November 10, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Changes made in the code directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants