Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong values in hetzner ccm quickstart docs for hcloud only clusters #1444

Closed
timkrase opened this issue Aug 15, 2024 · 1 comment · Fixed by #1468
Closed

Wrong values in hetzner ccm quickstart docs for hcloud only clusters #1444

timkrase opened this issue Aug 15, 2024 · 1 comment · Fixed by #1468

Comments

@timkrase
Copy link

/kind bug

What steps did you take and what happened:
Tried to install the hetzner ccm in a hcloud only cluster. Since #1415 , the helm command in the docs looks like this:
`helm repo add hcloud https://charts.hetzner.cloud
helm repo update hcloud

KUBECONFIG=$CAPH_WORKER_CLUSTER_KUBECONFIG helm upgrade --install hccm hcloud/hcloud-cloud-controller-manager --version 1.20.0
--namespace kube-system
--set secret.name=hetzner
--set secret.tokenKeyName=hcloud
--set privateNetwork.enabled=false`

Unfortunately, this does not seem to work, as the secret is not correctly initialized. The container therefore fails to be created.
Following Management cluster setup of the docs, the secret is created with the name "hetzner" and key "hcloud". Hetzner ccm expects a secret with name "hcloud" and key "token" though by default (hetzner ccm values.yaml.

I ended up installing ccm with the following helm command: helm upgrade --install hccm hcloud/hcloud-cloud-controller-manager -n kube-system --version 1.20.0 --namespace kube-system --set env.HCLOUD_TOKEN.valueFrom.secretKeyRef.name=hetzner --set env.HCLOUD_TOKEN.valueFrom.secretKeyRef.key=hcloud

It was just a quick test from my side, I don't know how/if the private network value needs to be adjusted too.

@guettli
Copy link
Collaborator

guettli commented Aug 30, 2024

I am reproducing it, and can confirm:

❯ kubectl get events  --sort-by='.lastTimestamp' -A| grep -v Normal

kube-system 65s Warning   Failed   pod/hcloud-cloud-controller-manager-.. Error: secret "hcloud" not found

guettli added a commit that referenced this issue Aug 30, 2024
Fixes #1444 Thank you @timkrase for reporting and providing a solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants