-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Adding Vaultwarden chart #83
base: main
Are you sure you want to change the base?
Conversation
0f275f5
to
7334633
Compare
7334633
to
824c790
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, are the default values in the table on README.md really the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure the default values in the table are correct. For all values.
|
||
| Name | Description | Value | | ||
| ---------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------ | | ||
| `server.env.sso.enabled` | Specifies whether sso should be enabled or not | `true` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You disabled it by default in the last commit, but you didn't change the default value in the documentation to reflect that
| `server.env.sso.clientId` | Specifies the value of the clientid if specified which will be placed in the config Map, this will cause the application ignore the clientIdFromSecret values set in the secret | `""` | | ||
| `server.env.sso.clientSecret` | Specifies the value of the clientSecret if specified which will be placed in the config Map, this will cause the application ignore the clientSecretFromSecret values set in the secret | `""` | | ||
| `server.env.sso.authority` | Specifies the value of the authority if specified which will be placed in the config Map, this will cause the application ignore the authorityFromSecret values set in the secret | `""` | | ||
| `server.env.sso.disablePasswordLogin` | Specifies whether disablePasswordLogin should be enabled or not | `true` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
What type of PR is this?
/kind feature
/SSO feature has been added to chart
TODOs: