Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Adding Vaultwarden chart #83

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

✨ Adding Vaultwarden chart #83

wants to merge 4 commits into from

Conversation

lucasrattz
Copy link
Contributor

@lucasrattz lucasrattz commented Jan 23, 2024

What type of PR is this?
/kind feature
/SSO feature has been added to chart

TODOs:

  • squashed commits
  • includes documentation

charts/vaultwarden/README.md Outdated Show resolved Hide resolved
charts/vaultwarden/values.yaml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@lucasrattz lucasrattz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, are the default values in the table on README.md really the default?

Copy link
Contributor Author

@lucasrattz lucasrattz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the default values in the table are correct. For all values.


| Name | Description | Value |
| ---------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------ |
| `server.env.sso.enabled` | Specifies whether sso should be enabled or not | `true` |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You disabled it by default in the last commit, but you didn't change the default value in the documentation to reflect that

| `server.env.sso.clientId` | Specifies the value of the clientid if specified which will be placed in the config Map, this will cause the application ignore the clientIdFromSecret values set in the secret | `""` |
| `server.env.sso.clientSecret` | Specifies the value of the clientSecret if specified which will be placed in the config Map, this will cause the application ignore the clientSecretFromSecret values set in the secret | `""` |
| `server.env.sso.authority` | Specifies the value of the authority if specified which will be placed in the config Map, this will cause the application ignore the authorityFromSecret values set in the secret | `""` |
| `server.env.sso.disablePasswordLogin` | Specifies whether disablePasswordLogin should be enabled or not | `true` |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants