Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin module version used for addon #49

Closed
wants to merge 2 commits into from
Closed

fix: Pin module version used for addon #49

wants to merge 2 commits into from

Conversation

bryantbiggs
Copy link
Contributor

@bryantbiggs
Copy link
Contributor Author

@manuelbcd can we get this quickly reviewed and merged, please

@fcarta29
Copy link

fcarta29 commented Jun 6, 2023

I think the following needs to be updated as well

source = "github.com/aws-ia/terraform-aws-eks-blueprints//modules/kubernetes-addons"

@manuelbcd
Copy link
Collaborator

Hey @bryantbiggs @fcarta29 , let me test it asap today and give feedback, thanks!

@manuelbcd
Copy link
Collaborator

@bryantbiggs @fcarta29 this version shed several errors when testing with Terraform plan, any suggestion?

╷
│ Error: Unsupported argument
│ 
│   on main.tf line 92, in module "eks_blueprints":
│   92:   cluster_name    = local.cluster_name
│ 
│ An argument named "cluster_name" is not expected here.
╵
╷
│ Error: Unsupported argument
│ 
│   on main.tf line 93, in module "eks_blueprints":
│   93:   cluster_version = "1.23"
│ 
│ An argument named "cluster_version" is not expected here.
╵
╷
│ Error: Unsupported argument
│ 
│   on main.tf line 95, in module "eks_blueprints":
│   95:   vpc_id             = module.vpc.vpc_id
│ 
│ An argument named "vpc_id" is not expected here.
╵
╷
│ Error: Unsupported argument
│ 
│   on main.tf line 96, in module "eks_blueprints":
│   96:   private_subnet_ids = module.vpc.private_subnets
│ 
│ An argument named "private_subnet_ids" is not expected here.
╵
╷
│ Error: Unsupported argument
│ 
│   on main.tf line 98, in module "eks_blueprints":
│   98:   managed_node_groups = {
│ 
│ An argument named "managed_node_groups" is not expected here.
╵
╷
│ Error: Unsupported argument
│ 
│   on main.tf line 125, in module "eks_blueprints":
│  125:   tags = local.tags
│ 
│ An argument named "tags" is not expected here.

@bryantbiggs bryantbiggs changed the title fix: Temporarily re-add internal cyclical dependencies fix: Pin module version used for addon Jun 16, 2023
@fcarta29
Copy link

@manuelbcd - Were you able to resolve the issues you were seeing? If so any chance we can get this PR merged and a release cut with the pinned version?

@manuelbcd
Copy link
Collaborator

sure Frank, let me have a look to it

@manuelbcd
Copy link
Collaborator

Changes applied one by one in a different branch. Thank you

@manuelbcd manuelbcd closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants