Update the AMI update workflow #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `updatecli` as a matrix is preferred because it simplifies the management of needing to update several families of OS types in a common, but separate manner. Unfortunately there appears to be an odd behavior with parallel executions of the updatecli tool that results in each parallel run of the matrix using the same git branch name, which results in a combination of either experienceing git fast-forward errors, or more than one OS family's worth of updates on the same PR. This change restricts the matrix to only being able to run serially until a more optimal solution can be found.
Due to `updatecli` creating a hash of the config files before the templates are rendered, all runs of `updatecli` triggered by GitHub were using the same branch name, which was causing collisions. this change modifies the workflow to use `envsubst` to template out the new config files before handing them to `updatecli` so that the generated hashes, and therefore branch names, are different so that we get unique PRs per OS and driver type
* the value for OWNER_ID was being converted to exponential values by the go templating engine and needed to be quoted so that they were evaluated as strings * fix the `if "a" == "b"` logic in favor of the correct `if eq "a" "b"` logic
aroberts87
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.